-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getMeetingDetailsVerbose Interface #2489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadahiya-MSFT
previously approved these changes
Sep 25, 2024
TrevorJoelHarris
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one last request to split EmailAddress and its test into separate files
…OfficeDev/microsoft-teams-library-js into johnsle/update_caller_interface
TrevorJoelHarris
previously approved these changes
Oct 2, 2024
KangxuanYe
requested changes
Oct 2, 2024
KangxuanYe
approved these changes
Oct 3, 2024
TrevorJoelHarris
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
This PR modifies the return interface of the
getMeetingDetailsVerbose
API. Specifically, theresponse.details.originalCaller
andresponse.details.dialedEntity
properties.originalCaller
represents the caller of a call, anddialedEntity
represents the callee. Those two properties originally were of typestring
, and the return value could've been either an email or phone number in string format.With this change, two additional properties were added to replace them:
originalCallerInfo
anddialedEntityInfo
. Those two properties are of a new typeICallParticipantIdentifiers
. This new typeICallParticipantIdentifiers
is an object that has 2 explicit fields forphoneNumber
andemail
.This new type serves two purposes: 1. The returned value is more explicitly defined 2. The response can return both a phone number and email if that information can be retrieved.
In addition, this change also a new optional property,
callId
.This PR is a follow up to the original PR that first introduced the
getMeetingDetailsVerbose
API:#2206
Main changes in the PR:
ICallParticipantIdentifiers
response.details.originalCaller
andresponse.details.dialedEntity
response.details.originalCallerInfo
andresponse.details.dialedEntityInfo
of the new interfaceICallParticipantIdentifiers
callId
Validation
Validation performed:
response.details.originalCaller
andresponse.details.dialedEntity
properties in a supported hostUnit Tests added:
Updated existing test
End-to-end tests added:
Updated existing test
Additional Requirements
Change file added:
Yes, added change file
Related PRs:
Original getMeetingDetailsVerbose PR: #2206